Skip to content

docs: Advanced Guides > Compotion API > Provide / Inject の翻訳 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bobstrange
Copy link
Contributor

Description of Problem

resolve #35

v3.vuejs.org/guide/composition-api-Provide-Inject.html の翻訳をしました。

用語は Provide / Inject に合わせています。

Proposed Solution

Additional Information

@netlify
Copy link

netlify bot commented Sep 28, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit bf4f54a

https://deploy-preview-96--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました。
翻訳内容については大丈夫です。
コメントした細々ですが、よろしくお願いします! 🙏


Let's assume that we want to rewrite the following code, which contains a `MyMap` component that provides a `MyMarker` component with the user's location, using the Composition API.
## シナリオの背景

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの改行ですが削除して原文と同じような行構成でお願いします。:pray:
今後のドキュメントのメンテナンス上、なるべく diff によるコンフリクトを避けるためです。


When using `provide` in `setup()`, we start by explicitly importing the method from `vue`. This allows us to define each property with its own invocation of `provide`.
`setup()` 内で `provide` を使う場合、始めに `vue` から明示的に `provide` をインポートします。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの改行ですが、前と同じく、削除して原文と同じような行構成でお願いします。🙏

## Using Inject
## Inject の使い方

同様に `setup()` 内 `inject` を使う場合も `vue` から明示的に `inject` をインポートする必要があります。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文章構成についても、改行を同じく原文と同じ構成で維持お願いします! 🙏

Co-authored-by: kazuya kawaguchi <kawakazu80@gmail.com>
@bobstrange bobstrange force-pushed the translation/composition-api/provide-inject branch 2 times, most recently from e0e0500 to d3d3d09 Compare September 29, 2020 03:02
@bobstrange bobstrange force-pushed the translation/composition-api/provide-inject branch from d3d3d09 to bf4f54a Compare September 29, 2020 03:02
@bobstrange bobstrange requested a review from kazupon September 29, 2020 03:08
@bobstrange
Copy link
Contributor Author

@kazupon
レビューありがとうございます :-)
指摘していただいた箇所について修正しました。
再度ご確認よろしくお願いします 🙇

@kazupon
Copy link
Member

kazupon commented Sep 29, 2020

対応ありがとうございました!
確認しました!
LGTMです! 👍
CIでエラーが起きていますが、翻訳作業に師匠がない(このPRとは別事象)なので、マージします!

翻訳ありがとうございました!

@kazupon kazupon merged commit deed18f into vuejs-jp:lang-ja Sep 29, 2020
@bobstrange bobstrange deleted the translation/composition-api/provide-inject branch September 29, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Guides > Compotion API > Provide / Inject の翻訳
2 participants